Skip to content

Ensure home directory exists #144003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Ensure home directory exists #144003

merged 1 commit into from
Jul 16, 2025

Conversation

ChrisDenton
Copy link
Member

This works around a missing mingw home directory in CI.

@ChrisDenton
Ensure home directory exists
262d02e 
This works around a missing mingw home directory in CI
@rustbot
Copy link
Collaborator

rustbot commented Jul 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2025
@ChrisDenton
Copy link
Member Author

@bors r+ p=101

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

📌 Commit 262d02e has been approved by ChrisDenton

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jul 16, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2025
@bors
Copy link
Collaborator

bors commented Jul 16, 2025

⌛ Testing commit 262d02e with merge 231257f...

@ChrisDenton ChrisDenton mentioned this pull request Jul 16, 2025
Closed
@bors
Copy link
Collaborator

bors commented Jul 16, 2025

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 231257f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 16, 2025
@bors bors merged commit 231257f into rust-lang:master Jul 16, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3014e79 (parent) -> 231257f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 231257f583c6e782da2e642ad007fca4e76779d6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3690.3s -> 5458.5s (47.9%)
  2. x86_64-msvc-2: 7300.8s -> 10509.8s (44.0%)
  3. dist-aarch64-msvc: 5414.6s -> 7575.2s (39.9%)
  4. aarch64-msvc-2: 5089.2s -> 7111.3s (39.7%)
  5. x86_64-msvc-1: 9148.5s -> 12517.6s (36.8%)
  6. aarch64-msvc-1: 6535.3s -> 8850.3s (35.4%)
  7. dist-apple-various: 6072.8s -> 7965.6s (31.2%)
  8. pr-check-2: 2193.7s -> 2636.0s (20.2%)
  9. pr-check-1: 1531.7s -> 1727.2s (12.8%)
  10. dist-aarch64-apple: 6478.3s -> 5657.6s (-12.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (231257f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.8% [-3.8%, -3.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.8% [-3.8%, -3.8%] 1

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.0% [-0.0%, -0.0%] 1
All ❌✅ (primary) - - 0

Bootstrap: 465.928s -> 466.648s (0.15%)
Artifact size: 374.79 MiB -> 374.71 MiB (-0.02%)

@ChrisDenton ChrisDenton deleted the ci4 branch July 16, 2025 11:50
@jieyouxu jieyouxu added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-CI Area: Our Github Actions CI CI-GHA-Windows-Server-2022 GitHub Actions: Windows Server 2022 runner images beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 17, 2025
@jieyouxu jieyouxu mentioned this pull request Jul 21, 2025
Merged
@jieyouxu jieyouxu added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jul 21, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Jul 21, 2025 •
edited
Loading

Unilaterally marking this as beta-accepted because beta backport will obviously need this too...

cc #144087 (comment)

@cuviper cuviper modified the milestones: 1.90.0, 1.89.0 Jul 21, 2025
bors added a commit that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144087 - cuviper:beta-next, r=cuviper
20c571f 
[beta] backports

- Taint body on invalid call ABI #142983
- Fix rustdoc not correctly showing attributes with re-exports #143083
- trait_sel: `MetaSized` always holds temporarily #144016
- Ensure home directory exists #144003

r? cuviper
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144003 - ChrisDenton:ci4, r=ChrisDenton
ad75f32 
Ensure home directory exists

This works around a missing mingw home directory in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-CI Area: Our Github Actions CI beta-accepted Accepted for backporting to the compiler in the beta channel. CI-GHA-Windows-Server-2022 GitHub Actions: Windows Server 2022 runner images merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ChrisDenton @rustbot @bors @rust-timer @jieyouxu @cuviper @Mark-Simulacrum